dongjoon-hyun commented on code in PR #1292: URL: https://github.com/apache/orc/pull/1292#discussion_r1005000532
########## java/bench/fetch-data.sh: ########## @@ -15,8 +15,18 @@ # See the License for the specific language governing permissions and # limitations under the License. mkdir -p data/sources/taxi -(cd data/sources/taxi; wget https://s3.amazonaws.com/nyc-tlc/trip+data/yellow_tripdata_2015-11.parquet ) -(cd data/sources/taxi; wget https://s3.amazonaws.com/nyc-tlc/trip+data/yellow_tripdata_2015-12.parquet ) +(cd data/sources/taxi; wget https://d37ci6vzurychx.cloudfront.net/trip-data/yellow_tripdata_2015-11.parquet ) +(cd data/sources/taxi; wget https://d37ci6vzurychx.cloudfront.net/trip-data/yellow_tripdata_2015-12.parquet ) + +if [ $? -ne 0 ]; then + echo "Download taxi failed." + exit 255 +fi mkdir -p data/sources/github (cd data/sources/github; wget http://data.gharchive.org/2015-11-{01..15}-{0..23}.json.gz) + +if [ $? -ne 0 ]; then + echo "Download data failed." + exit 255 +fi Review Comment: Ditto. We don't need to check all commands one by one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
