wgtmac commented on PR #1295:
URL: https://github.com/apache/orc/pull/1295#issuecomment-1292221785
The **Build on Windows** workflow failed due to an outdated MSVC compiler
but reported a success. That's weird.
```bash
Run mkdir build
mkdir build
cd build
cmake .. -G "Visual Studio 14
[2](https://github.com/apache/orc/actions/runs/3326738087/jobs/5500752547#step:4:2)015
Win64" -DCMAKE_BUILD_TYPE=Debug -DBUILD_LIBHDFSPP=OFF -DBUILD_TOOLS=OFF
-DBUILD_JAVA=OFF
cmake --build . --config Debug
ctest -C Debug --output-on-failure
shell: C:\Program Files\PowerShell\7\pwsh.EXE -command ". '{0}'"
Directory: D:\a\orc\orc
Mode LastWriteTime Length Name
---- ------------- ------ ----
d---- 10/26/2022 6:59 AM build
-- Selecting Windows SDK version
10.0.14[3](https://github.com/apache/orc/actions/runs/3326738087/jobs/5500752547#step:4:3)93.0
to target Windows 10.0.17763.
-- The C compiler identification is MSVC
19.0.2[4](https://github.com/apache/orc/actions/runs/3326738087/jobs/5500752547#step:4:4)24[5](https://github.com/apache/orc/actions/runs/3326738087/jobs/5500752547#step:4:5).0
-- The CXX compiler identification is MSVC 19.0.24245.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Program Files
(x8[6](https://github.com/apache/orc/actions/runs/3326738087/jobs/5500752547#step:4:6))/Microsoft
Visual Studio 14.0/VC/bin/x86_amd64/cl.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual
Studio 14.0/VC/bin/x86_amd64/cl.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Build type: Debug
-- compiler MSVC version 19.0.24245.0
-- Performing Test
CPP1[7](https://github.com/apache/orc/actions/runs/3326738087/jobs/5500752547#step:4:7)_FLAG_SUPPORTED
-- Performing Test CPP17_FLAG_SUPPORTED - Failed
CMake Error at CMakeLists.txt:151 (message):
A c++17-compliant compiler is required
-- Configuring incomplete, errors occurred!
See also "D:/a/orc/orc/build/CMakeFiles/CMakeOutput.log".
See also "D:/a/orc/orc/build/CMakeFiles/CMakeError.log".
Microsoft (R) Build Engine version
16.11.2+f3225[9](https://github.com/apache/orc/actions/runs/3326738087/jobs/5500752547#step:4:10)642
for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.
MSBUILD : error
MSB[10](https://github.com/apache/orc/actions/runs/3326738087/jobs/5500752547#step:4:11)09:
Project file does not exist.
Switch: ALL_BUILD.vcxproj
Test project D:/a/orc/orc/build
No tests were found!!!
```
I have successfully built the ORC lib with C++17 enabled on my Windows
desktop, which has installed Visual Studio 2022. Though the orc-tool keeps
failing missing "getopt.h", we need to fix the Windows workflow anyway before
merging this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
