dongjoon-hyun commented on code in PR #1307:
URL: https://github.com/apache/orc/pull/1307#discussion_r1014774374
##########
c++/include/orc/Type.hh:
##########
@@ -70,10 +70,11 @@ namespace orc {
/**
* Create a row batch for this type.
*/
- virtual ORC_UNIQUE_PTR<ColumnVectorBatch> createRowBatch(uint64_t size,
- MemoryPool& pool,
- bool encoded =
false
- ) const = 0;
+ virtual ORC_UNIQUE_PTR<ColumnVectorBatch> createRowBatch(
+ uint64_t size,
+ MemoryPool& pool,
+ bool encoded = false,
+ bool enableFixedWidthNumericVectorBatch = false) const = 0;
Review Comment:
In addition, can we keep the original three-parameter method and add new
four-parameter method with new parameter additionally?
```
bool enableFixedWidthNumericVectorBatch = false) const = 0;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
