guiyanakuang commented on code in PR #1305:
URL: https://github.com/apache/orc/pull/1305#discussion_r1014778205
##########
java/core/src/java/org/apache/orc/OrcUtils.java:
##########
@@ -318,15 +317,15 @@ TypeDescription
convertTypeFromProtobuf(List<OrcProto.Type> types,
result = TypeDescription.createDate();
break;
case DECIMAL: {
- result = TypeDescription.createDecimal();
- if (type.hasScale()) {
- result.withScale(type.getScale());
- }
- if (type.hasPrecision()) {
- result.withPrecision(type.getPrecision());
- }
+ result = TypeDescription.createDecimal();
+ if (type.hasScale()) {
+ result.withScale(type.getScale());
}
- break;
+ if (type.hasPrecision()) {
+ result.withPrecision(type.getPrecision());
+ }
+ }
+ break;
Review Comment:
When {} is present, the new rule expects the break indent to be the same as
the case, 6 spaces.
I have now removed the {}.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
