wgtmac commented on PR #1308: URL: https://github.com/apache/orc/pull/1308#issuecomment-1306541500
> Thanks for adding this! One concern is that this PR touch most of the c++ codes. `git blame` will always point to this PR. It seems that keeping the indent inside namespace can save many changes. Probably we can have a try? That's a good catch! Let me add `NamespaceIndentation:All` to reduce lines of change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
