HuwCampbell opened a new pull request, #1385:
URL: https://github.com/apache/orc/pull/1385

   The C++ implementation handles when the postscript doesn't include 
compressionBlockSize by checking if it is set and using 256 * 1024 if it is not.
   
   ### What changes were proposed in this pull request?
   
   As compressionBlockSize is optional this means valid files couldn't be read 
with the Java implementation. This change brings the Java implemenation in line 
with C++ by first checking and using the same default value.
   
   ### Why are the changes needed?
   
   Some files which can be read by C++ fail to be read when compression is 
enabled in the Java implementation because it uses a default buffer of size 0 
(which is just an arbitrary protobuf 'nil' conversion).
   
   ### How was this patch tested?
   
   To be honest, I just thought about it for a minute.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to