pavibhai commented on code in PR #1387:
URL: https://github.com/apache/orc/pull/1387#discussion_r1103015288


##########
java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java:
##########
@@ -1290,7 +1290,12 @@ private void clearStreams() {
   private void readStripe() throws IOException {
     StripeInformation stripe = beginReadStripe();
     planner.parseStripe(stripe, fileIncluded);
-    includedRowGroups = pickRowGroups();
+    try {
+      includedRowGroups = pickRowGroups();
+    } catch (Throwable e) {

Review Comment:
   Let me give a split answer on this:
   
   * When the inconsistent issue happens should we continue reading? Yes as 
this is well-defined on what the issue is i.e. row index stride is set but 
indexes have not been written.
   * Should other issues in reading indexes be intercepted? The general answer 
here is no, as we don't know what the issue is that you are encountering so we 
don't know if it is correct to intercept it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to