wgtmac commented on PR #1375: URL: https://github.com/apache/orc/pull/1375#issuecomment-1429331452
> @wgtmac May I have a question about your suggestion "The options to enable AVX512 at compile and runtime are still confusing. The goal is to add one cmake option to control if AVX512 should be compiled. At runtime, we simply need an environment variable to enable/disable AVX512 at runtime if AVX512 has been compiled. We don't need to do the same thing as Apache Arrow because it has a different context." > > Currently, I added a cmake option "BUILD_ENABLE_AVX512" to control if AVX512 code should be compiled. (For example, cmake command: cmake .. -DCMAKE_BUILD_TYPE=debug -DBUILD_JAVA=OFF -DBUILD_ENABLE_AVX512=ON) Then, if BUILD_ENABLE_AVX512 is on, a macro "ORC_HAVE_RUNTIME_AVX512" will be defined in the cmake process. It will enable the build of AVX512 code in the make process. > > I also created an ENV parameter "ORC_USER_SIMD_LEVEL" whose value could be "none" or "avx512", to determine if enable /disable AVX512 at the runtime. > > What is the confusing process? Is the ENV parameter name "ORC_USER_SIMD_LEVEL" too similar to the macro "ORC_HAVE_RUNTIME_AVX512"? or others? Thank you very much! From the statement above, adding `BUILD_ENABLE_AVX512` and `ORC_USER_SIMD_LEVEL` is enough. `ORC_SIMD_LEVEL` is redundant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
