guiyanakuang commented on PR #1421: URL: https://github.com/apache/orc/pull/1421#issuecomment-1443861467
> > I think it would be simpler if I would show you what I had in mind: https://github.com/zabetak/orc/tree/ORC-1378 > > @guiyanakuang @zabetak The biggest difference between this PR and @zabetak 's PR ’is whether to add dependency (not dependency management) to pom. > >  Sorry, in the example I provided, I added the slf4j-simple with the runtime scope in the parent pom.xml dependencies instead of the dependency management section. I now realize that this could be harmful. Before this change, orc-core did not transitively pass any log implementation jar. After adding slf4j-simple to the parent pom.xml dependencies, it will transitively pass it, which may cause a log library conflict for projects that depend on orc-core. Therefore, I think @zabetak's approach is better. Additionally, we can add slf4j-simple with the provided scope to orc-core, which can avoid transitive dependencies and also enable logging output when testing orc-core. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
