dongjoon-hyun commented on PR #1411:
URL: https://github.com/apache/orc/pull/1411#issuecomment-1461330790

   Ah, sorry guys. I found that `branch-1.8` is not compatible with this patch.
   ```
   $ ./run-all.sh apache branch-1.8
   Launching centos7 as 67566
   Launching debian10 as 67567
   Launching debian11 as 67568
   Launching ubuntu18 as 67569
   Launching ubuntu20 as 67570
   Launching ubuntu22 as 67571
   Launching fedora37 as 67572
   Launching debian10_jdk=11 as 67573
   Launching ubuntu20_jdk=11 as 67574
   Launching ubuntu20_jdk=11_cc=clang as 67576
   Waiting for 67566
   Failed tests
   FAILED centos7
   FAILED debian10_jdk=11
   FAILED debian10
   FAILED ubuntu18
   FAILED ubuntu20_jdk=11_cc=clang
   FAILED ubuntu20_jdk=11
   FAILED ubuntu20
   ```
   
   It seems to fail during ZSTD building at old OSes while 
Ubuntu22/Debian11/Fedora37 looks working. I guess this is not a bug. Instead, 
we did C++ compilation update only at main branch. 
   ```
   [ 18%] Performing configure step for 'zstd_ep'
   CMake Error at 
/root/orc/build/zstd_ep-prefix/src/zstd_ep-stamp/zstd_ep-configure-RELWITHDEBINFO.cmake:16
 (message):
     Command failed: 1
   
      '/usr/bin/cmake' 
'-DCMAKE_INSTALL_PREFIX=/root/orc/build/c++/libs/thirdparty/zstd_ep-install' 
'-DBUILD_SHARED_LIBS=OFF' '-DCMAKE_INSTALL_LIBDIR=lib' '-GUnix Makefiles' 
'/root/orc/build/zstd_ep-prefix/src/zstd_ep/build/cmake'
   
     See also
   
       /root/orc/build/zstd_ep-prefix/src/zstd_ep-stamp/zstd_ep-configure-*.log
   
   
   make[2]: *** [zstd_ep-prefix/src/zstd_ep-stamp/zstd_ep-configure] Error 1
   make[1]: *** [CMakeFiles/zstd_ep.dir/all] Error 2
   CMakeFiles/zstd_ep.dir/build.make:106: recipe for target 
'zstd_ep-prefix/src/zstd_ep-stamp/zstd_ep-configure' failed
   CMakeFiles/Makefile2:178: recipe for target 'CMakeFiles/zstd_ep.dir/all' 
failed
   make: *** [all] Error 2
   Makefile:162: recipe for target 'all' failed
   ```
   
   I'll revert zstd dependency to the old one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to