wpleonardo commented on code in PR #1375: URL: https://github.com/apache/orc/pull/1375#discussion_r1138687810
########## c++/src/CMakeLists.txt: ########## @@ -184,7 +184,11 @@ set(SOURCE_FILES Timezone.cc TypeImpl.cc Vector.cc - Writer.cc) + Writer.cc + CpuInfoUtil.cc + BpackingDefault.cc + BpackingAvx512.cc + Bpacking.cc) Review Comment: https://github.com/wpleonardo/orc/blob/fe5b6c7a29721bb5d8c4699a0b072d64555d600d/c%2B%2B/src/CMakeLists.txt#L196 Already changed the building source_files when Build_Enable_AVX512 is true. And also changed the function definitions about BitUnpack::readLongs, BitUnpackDefault::readLongs, and BitUnpackAVX512::readLongs https://github.com/wpleonardo/orc/blob/fe5b6c7a29721bb5d8c4699a0b072d64555d600d/c%2B%2B/src/RleDecoderV2.cc#L75 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
