wgtmac commented on code in PR #1375:
URL: https://github.com/apache/orc/pull/1375#discussion_r1148758780


##########
README.md:
##########
@@ -93,3 +93,15 @@ To build only the C++ library:
 % make test-out
 
 ```
+
+To build the C++ library with AVX512 enabling:

Review Comment:
   ```suggestion
   To build the C++ library with AVX512 enabled:
   ```



##########
README.md:
##########
@@ -93,3 +93,15 @@ To build only the C++ library:
 % make test-out
 
 ```
+
+To build the C++ library with AVX512 enabling:
+```shell
+ENV parameter ORC_USER_SIMD_LEVEL is to switch "AVX512" and "NONE" at the 
running time.
+export ORC_USER_SIMD_LEVEL=AVX512
+% mkdir build
+% cd build
+% cmake .. -DBUILD_JAVA=OFF -DBUILD_ENABLE_AVX512=ON
+% make package
+% make test-out
+

Review Comment:
   Remove blank line



##########
README.md:
##########
@@ -93,3 +93,15 @@ To build only the C++ library:
 % make test-out
 
 ```
+
+To build the C++ library with AVX512 enabling:
+```shell
+ENV parameter ORC_USER_SIMD_LEVEL is to switch "AVX512" and "NONE" at the 
running time.

Review Comment:
   ```suggestion
   Environment variable ORC_USER_SIMD_LEVEL can be set to "AVX512" or "NONE" at 
compile and/or run time. At compile time, it defines the SIMD level to be 
compiled into the binaries. At run time, it defines the SIMD level to dispatch 
the code which can apply SIMD optimization. Note that if ORC_USER_SIMD_LEVEL is 
set to "NONE" at compile time, ORC_USER_SIMD_LEVEL will not take effect at run 
time even if it is set to "AVX512".
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to