wpleonardo commented on code in PR #1375:
URL: https://github.com/apache/orc/pull/1375#discussion_r1169459804
##########
c++/src/RLEv2.hh:
##########
@@ -166,6 +166,20 @@ namespace orc {
void next(int16_t* data, uint64_t numValues, const char* notNull) override;
+ unsigned char readByte(char** bufStart, char** bufEnd);
+
+ /**
+ * Most hotspot of this function locates in saving stack, so inline this
function to have
+ * performance gain.
+ */
+ inline void resetBufferStart(char** bufStart, char** bufEnd, uint64_t len,
bool resetBuf,
+ uint32_t backupLen);
+
+ char* bufferStart;
+ char* bufferEnd;
+ uint32_t bitsLeft; // Used by readLongs when bitSize < 8
+ uint32_t curByte; // Used by anything that uses readLongs
Review Comment:
Already change these parameters back to private, and added the set/get
functions to access them.
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
