dongjoon-hyun commented on code in PR #1420:
URL: https://github.com/apache/orc/pull/1420#discussion_r1237855827


##########
c++/src/wrap/orc-proto-wrapper.cc:
##########
@@ -32,6 +32,7 @@ DIAGNOSTIC_IGNORE("-Wmissing-variable-declarations")
 DIAGNOSTIC_IGNORE("-Wnested-anon-types")
 DIAGNOSTIC_IGNORE("-Wreserved-id-macro")
 DIAGNOSTIC_IGNORE("-Wshorten-64-to-32")
+DIAGNOSTIC_IGNORE("-Wsuggest-destructor-override")

Review Comment:
   During https://github.com/apache/orc/issues/1532, I found that this broke 
Clang 10 due to `unknown warning group`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to