dongjoon-hyun commented on code in PR #1546:
URL: https://github.com/apache/orc/pull/1546#discussion_r1238079654
##########
CMakeLists.txt:
##########
@@ -136,6 +136,8 @@ if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
set (WARN_FLAGS "${WARN_FLAGS} -Wno-c++2a-compat
-Wno-unknown-warning-option -Wno-suggest-override
-Wno-suggest-destructor-override")
elseif (CMAKE_HOST_APPLE AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER
"11.0")
set (WARN_FLAGS "${WARN_FLAGS} -Wno-c++2a-compat")
+ elseif (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "10.0")
+ set (WARN_FLAGS "${WARN_FLAGS} -Wno-suggest-override
-Wno-suggest-destructor-override -Wno-implicit-fallthrough")
Review Comment:
To avoid any code change in this test coverage PR, I simply excluded the
existing errors on Clang 10. Given that higher Clang has no issues, I believe
we can ignore these. Eventually, we will drop Clang 10.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
