dongjoon-hyun commented on code in PR #1500:
URL: https://github.com/apache/orc/pull/1500#discussion_r1238261627
##########
c++/src/ConvertColumnReader.cc:
##########
@@ -257,169 +603,169 @@ namespace orc {
switch (fileType.getKind()) {
case BOOLEAN: {
switch (_readType.getKind()) {
- CASE_CREATE_READER(BYTE, BooleanToByte);
- CASE_CREATE_READER(SHORT, BooleanToShort);
- CASE_CREATE_READER(INT, BooleanToInt);
- CASE_CREATE_READER(LONG, BooleanToLong);
- CASE_CREATE_READER(FLOAT, BooleanToFloat);
- CASE_CREATE_READER(DOUBLE, BooleanToDouble);
+ CASE_CREATE_READER(BYTE, BooleanToByte)
+ CASE_CREATE_READER(SHORT, BooleanToShort)
+ CASE_CREATE_READER(INT, BooleanToInt)
+ CASE_CREATE_READER(LONG, BooleanToLong)
+ CASE_CREATE_READER(FLOAT, BooleanToFloat)
+ CASE_CREATE_READER(DOUBLE, BooleanToDouble)
+ CASE_CREATE_READER(STRING, BooleanToString)
+ CASE_CREATE_READER(CHAR, BooleanToChar)
+ CASE_CREATE_READER(VARCHAR, BooleanToVarchar)
+ CASE_CREATE_DECIMAL_READER(Boolean)
+ CASE_CREATE_READER(TIMESTAMP, BooleanToTimestamp)
+ CASE_CREATE_READER(TIMESTAMP_INSTANT, BooleanToTimestamp)
case BOOLEAN:
- case STRING:
case BINARY:
- case TIMESTAMP:
case LIST:
case MAP:
case STRUCT:
case UNION:
- case DECIMAL:
case DATE:
- case VARCHAR:
- case CHAR:
- case TIMESTAMP_INSTANT:
CASE_EXCEPTION
}
}
case BYTE: {
switch (_readType.getKind()) {
- CASE_CREATE_READER(BOOLEAN, ByteToBoolean);
- CASE_CREATE_READER(SHORT, ByteToShort);
- CASE_CREATE_READER(INT, ByteToInt);
- CASE_CREATE_READER(LONG, ByteToLong);
- CASE_CREATE_READER(FLOAT, ByteToFloat);
- CASE_CREATE_READER(DOUBLE, ByteToDouble);
+ CASE_CREATE_READER(BOOLEAN, ByteToBoolean)
+ CASE_CREATE_READER(SHORT, ByteToShort)
+ CASE_CREATE_READER(INT, ByteToInt)
+ CASE_CREATE_READER(LONG, ByteToLong)
+ CASE_CREATE_READER(FLOAT, ByteToFloat)
+ CASE_CREATE_READER(DOUBLE, ByteToDouble)
+ CASE_CREATE_READER(STRING, ByteToString)
+ CASE_CREATE_READER(CHAR, ByteToChar)
+ CASE_CREATE_READER(VARCHAR, ByteToVarchar)
+ CASE_CREATE_DECIMAL_READER(Byte)
+ CASE_CREATE_READER(TIMESTAMP, ByteToTimestamp)
+ CASE_CREATE_READER(TIMESTAMP_INSTANT, ByteToTimestamp)
case BYTE:
- case STRING:
case BINARY:
- case TIMESTAMP:
case LIST:
case MAP:
case STRUCT:
case UNION:
- case DECIMAL:
case DATE:
- case VARCHAR:
- case CHAR:
- case TIMESTAMP_INSTANT:
CASE_EXCEPTION
}
}
case SHORT: {
switch (_readType.getKind()) {
- CASE_CREATE_READER(BOOLEAN, ShortToBoolean);
- CASE_CREATE_READER(BYTE, ShortToByte);
- CASE_CREATE_READER(INT, ShortToInt);
- CASE_CREATE_READER(LONG, ShortToLong);
- CASE_CREATE_READER(FLOAT, ShortToFloat);
- CASE_CREATE_READER(DOUBLE, ShortToDouble);
+ CASE_CREATE_READER(BOOLEAN, ShortToBoolean)
+ CASE_CREATE_READER(BYTE, ShortToByte)
+ CASE_CREATE_READER(INT, ShortToInt)
+ CASE_CREATE_READER(LONG, ShortToLong)
+ CASE_CREATE_READER(FLOAT, ShortToFloat)
+ CASE_CREATE_READER(DOUBLE, ShortToDouble)
+ CASE_CREATE_READER(STRING, ShortToString)
+ CASE_CREATE_READER(CHAR, ShortToChar)
+ CASE_CREATE_READER(VARCHAR, ShortToVarchar)
+ CASE_CREATE_DECIMAL_READER(Short)
+ CASE_CREATE_READER(TIMESTAMP, ShortToTimestamp)
+ CASE_CREATE_READER(TIMESTAMP_INSTANT, ShortToTimestamp)
case SHORT:
- case STRING:
case BINARY:
- case TIMESTAMP:
case LIST:
case MAP:
case STRUCT:
case UNION:
- case DECIMAL:
case DATE:
- case VARCHAR:
- case CHAR:
- case TIMESTAMP_INSTANT:
CASE_EXCEPTION
}
}
case INT: {
switch (_readType.getKind()) {
- CASE_CREATE_READER(BOOLEAN, IntToBoolean);
- CASE_CREATE_READER(BYTE, IntToByte);
- CASE_CREATE_READER(SHORT, IntToShort);
- CASE_CREATE_READER(LONG, IntToLong);
- CASE_CREATE_READER(FLOAT, IntToFloat);
- CASE_CREATE_READER(DOUBLE, IntToDouble);
+ CASE_CREATE_READER(BOOLEAN, IntToBoolean)
+ CASE_CREATE_READER(BYTE, IntToByte)
+ CASE_CREATE_READER(SHORT, IntToShort)
+ CASE_CREATE_READER(LONG, IntToLong)
+ CASE_CREATE_READER(FLOAT, IntToFloat)
+ CASE_CREATE_READER(DOUBLE, IntToDouble)
+ CASE_CREATE_READER(STRING, IntToString)
+ CASE_CREATE_READER(CHAR, IntToChar)
+ CASE_CREATE_READER(VARCHAR, IntToVarchar)
+ CASE_CREATE_DECIMAL_READER(Int)
+ CASE_CREATE_READER(TIMESTAMP, IntToTimestamp)
+ CASE_CREATE_READER(TIMESTAMP_INSTANT, IntToTimestamp)
case INT:
- case STRING:
case BINARY:
- case TIMESTAMP:
case LIST:
case MAP:
case STRUCT:
case UNION:
- case DECIMAL:
case DATE:
- case VARCHAR:
- case CHAR:
- case TIMESTAMP_INSTANT:
CASE_EXCEPTION
}
}
case LONG: {
switch (_readType.getKind()) {
- CASE_CREATE_READER(BOOLEAN, LongToBoolean);
Review Comment:
We need this semicolon removal in `branch-1.9` too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
