wgtmac commented on code in PR #1565:
URL: https://github.com/apache/orc/pull/1565#discussion_r1288564335
##########
java/shims/src/java/org/apache/orc/impl/HadoopShims.java:
##########
@@ -35,6 +35,7 @@ enum DirectCompressionType {
ZLIB_NOHEADER,
ZLIB,
SNAPPY,
+ BROTLI,
Review Comment:
IIUC, shims here are used to workaround codec provided by Hadoop libraries
of different versions. It seems that we do not need this line.
##########
proto/orc_proto.proto:
##########
@@ -386,6 +386,7 @@ enum CompressionKind {
LZO = 3;
LZ4 = 4;
ZSTD = 5;
+ BROTLI = 6;
Review Comment:
In order to check this in, we'd better update the website and the C++ code
(at least throw an unimplemented exception on the reader side)
##########
java/core/pom.xml:
##########
@@ -72,6 +72,10 @@
<groupId>org.threeten</groupId>
<artifactId>threeten-extra</artifactId>
</dependency>
+ <dependency>
+ <groupId>com.github.rdblue</groupId>
Review Comment:
I found this one but not sure if it is mature enough:
https://github.com/hyperxpro/Brotli4j
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
