dongjoon-hyun commented on PR #1581: URL: https://github.com/apache/orc/pull/1581#issuecomment-1694746092
To be clear, I don't say there is a regression when we didn't change anything. IIRC, we didn't delete any real code during refactoring. It means we didn't introduce any `Unused Imports` newly. In other words, you cannot call it the existing code as a `regression`. > now that we have regression in place, shall we rework on this? BTW, thank you for the proposal, @mystic-lama. As you know, Apache ORC is an open source project and every contributor can propose everything. We are not blocking anything. However, to protect Apache ORC project, the committers are able to give +1 for a few selected proposals. For this category, I decided to exclude all `Import` rules like the following because there is no real business logic in `Java import` statement. To simply put, although I understand your passion, let's call it a day by ignoring these import rules for now at 2.0.0 because we changed a lot already. We may want to re-try to introduce more cleaner environment at Apache ORC 2.1.0. https://github.com/apache/orc/blob/81769064dc0e14aee0bc086a03e72d7a67047543/java/checkstyle-suppressions.xml#L45-L47 > Change Management Process is a way more organized in ORC and it's really good :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
