guiyanakuang commented on code in PR #1692:
URL: https://github.com/apache/orc/pull/1692#discussion_r1434796651
##########
java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java:
##########
@@ -747,8 +752,10 @@ static TruthValue evaluatePredicateRange(PredicateLeaf
predicate,
ValueRange range,
BloomFilter bloomFilter,
boolean useUTCTimestamp) {
+ // If range is invalid, that means that no value (including null) is
written to this column
+ // we should return TruthValue.NO for any predicate.
if (!range.isValid()) {
- return TruthValue.YES_NO_NULL;
+ return TruthValue.NO;
Review Comment:
This pr uses the following judgment instead of ORC-1075, which is more
accurate.
```java
if (statsProto == EMPTY_COLUMN_STATISTICS) {
return TruthValue.YES_NO_NULL;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
