dongjoon-hyun commented on code in PR #1722:
URL: https://github.com/apache/orc/pull/1722#discussion_r1442480774


##########
java/tools/src/java/org/apache/orc/tools/RowCount.java:
##########
@@ -54,7 +69,22 @@ public static void main(Configuration conf, String[] args) 
throws IOException {
     System.exit(bad == 0 ? 0 : 1);
   }
 
-  public static void main(String[] args) throws IOException {
+  public static void main(String[] args) throws Exception {
     main(new Configuration(), args);
   }
+
+  private static Options createOptions() {
+    Options result = new Options();
+
+    result.addOption(Option.builder()

Review Comment:
   Please add a short opt here.
   
   
https://github.com/apache/orc/blob/68f4a8bb970cb370faba6b907ae93164e3243042/java/tools/src/java/org/apache/orc/tools/FileDump.java#L786



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to