dongjoon-hyun commented on code in PR #1743:
URL: https://github.com/apache/orc/pull/1743#discussion_r1449146898
##########
java/core/src/java/org/apache/orc/impl/OrcCodecPool.java:
##########
@@ -42,6 +43,11 @@ public final class OrcCodecPool {
private static final int MAX_PER_KIND = 32;
public static CompressionCodec getCodec(CompressionKind kind) {
+ return getCodec(kind, OrcFile.CompressionZstdImpl.JAVA);
+ }
+
+ public static CompressionCodec getCodec(CompressionKind kind,
+ OrcFile.CompressionZstdImpl
zstdImpl) {
Review Comment:
Well, this doesn't look good because `getCodec` is a general pooling. Why do
we need to hand over `zstdImpl` when getting the codec every time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
