dongjoon-hyun commented on code in PR #1830: URL: https://github.com/apache/orc/pull/1830#discussion_r1507830888
########## cmake_modules/ThirdpartyToolchain.cmake: ########## @@ -72,6 +72,7 @@ endif () # ---------------------------------------------------------------------- # ORC Format ExternalProject_Add (orc-format_ep + URL "https://dlcdn.apache.org/orc/orc-format-${ORC_FORMAT_VERSION}/orc-format-${ORC_FORMAT_VERSION}.tar.gz"; URL "https://archive.apache.org/dist/orc/orc-format-${ORC_FORMAT_VERSION}/orc-format-${ORC_FORMAT_VERSION}.tar.gz"; Review Comment: According to https://cmake.org/cmake/help/latest/module/ExternalProject.html#url , this looks wrong to me. Have you tested this PR, @progval ? ``` URL <url1> [<url2>...] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
