ffacs commented on issue #1845: URL: https://github.com/apache/orc/issues/1845#issuecomment-1997090117
> Could we add `NOLINT` to those public/protected variables? Sorry for my confusing expression. What I mean just like below https://github.com/apache/orc/blob/e1f185eedd7dc0d9d60339117c9299f5b26ddeaf/c%2B%2B/src/ConvertColumnReader.cc#L26-L33 The `readType` is a protected member of `ConvertColumnReader`. if we still use `readType` as the name, we can`t uniform the naming of constructor parameter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
