wgtmac commented on code in PR #1867: URL: https://github.com/apache/orc/pull/1867#discussion_r1547143105
########## site/specification/ORCv1.md: ########## @@ -1155,6 +1155,9 @@ records non-null values, a DATA stream that records the number of seconds after 1 January 2015, and a SECONDARY stream that records the number of nanoseconds. +* Note that if writer timezone is set, 1 January 2015 is according to +this timezone and not according to UTC Review Comment: IIUC, writer timezone field is mandatory if there is any timestamp type: https://github.com/apache/orc/blob/513922af6c1d1a07e632a03231d5b546eeafb26e/java/core/src/java/org/apache/orc/impl/WriterImpl.java#L559-L565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
