h-vetinari commented on PR #1882:
URL: https://github.com/apache/orc/pull/1882#issuecomment-2046906363
OK, so the test I added passed now:
```
[ RUN ] TestTimezone.testTzdbFromCondaEnv
[ OK ] TestTimezone.testTzdbFromCondaEnv (0 ms)
```
but restoring `TZDIR` still fails:
```
unknown file: error: C++ exception with description "Time zone file
������������������������������������������������������������������������������/UTC
does not exist.
```
Since this is copied from `testMissingTZDB`, I'm surprised the same error
doesn't happen there, because that test is saving `tzDirBackup` in exactly the
same way - i.e. just a pointer to an environment variable which then gets
deleted. It seems to me that the restoration of that environment variable
cannot succeed (without a deepcopy before deleting `TZDIR`), and so far that
test may have only passed due to checking `if (tzDirBackup != nullptr)`, but -
potentially - never actually restored the environment variable...? 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
