wgtmac commented on code in PR #1888:
URL: https://github.com/apache/orc/pull/1888#discussion_r1564102897
##########
.github/workflows/build_and_test.yml:
##########
@@ -169,19 +169,20 @@ jobs:
formatting-check:
name: "C++ format check"
- runs-on: ubuntu-20.04
- strategy:
- matrix:
- path:
- - 'c++'
- - 'tools'
+ runs-on: ubuntu-latest
Review Comment:
nit: It would be better to use a fixed version. Otherwise, a breaking
upgrade may result in CI failures, e.g. unable to find a specific version of
clang tools.
##########
c++/build-support/REAMD.md:
##########
@@ -0,0 +1,30 @@
+# Build support
+
+The Python scripts under the folder provide capabilities for formatting code.
+Make sure you've installed `clang-format-13`, `clang-tidy-13` and
`clang-apply-replacements-13` and cmake could find them.
Review Comment:
Why not use a higher version? The latest is 19 already.
##########
CMakeLists.txt:
##########
@@ -15,6 +15,8 @@
# specific language governing permissions and limitations
# under the License.
+set(CMAKE_EXPORT_COMPILE_COMMANDS ON) # For clang-tidy.
Review Comment:
Is it better to move it to line 36?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
