cxzl25 commented on code in PR #1909:
URL: https://github.com/apache/orc/pull/1909#discussion_r1577523579
##########
java/bench/spark/pom.xml:
##########
@@ -171,8 +171,9 @@
<exclude>META-INF/NOTICE-binary</exclude>
<exclude>META-INF/NOTICE.md</exclude>
<exclude>META-INF/NOTICE.txt</exclude>
- <exclude>META-INF/DUMMY.SF</exclude>
- <exclude>META-INF/DUMMY.DSA</exclude>
+ <exclude>META-INF/*.SF</exclude>
+ <exclude>META-INF/*.DSA</exclude>
+ <exclude>META-INF/*.RSA</exclude>
Review Comment:
```
[WARNING] eclipse-collections-11.1.0.jar, eclipse-collections-api-11.1.0.jar
define 4 overlapping resources:
[WARNING] - LICENSE-EDL-1.0.txt
[WARNING] - LICENSE-EPL-1.0.txt
[WARNING] - META-INF/ECLIPSE_.RSA
[WARNING] - META-INF/ECLIPSE_.SF
```
<img width="473" alt="image"
src="https://github.com/apache/orc/assets/3898450/79eaf13b-9cca-4254-a5bf-650f7b5016d0";>
##########
java/bench/spark/src/java/org/apache/orc/bench/spark/SparkBenchmark.java:
##########
@@ -74,7 +74,7 @@
@BenchmarkMode(Mode.AverageTime)
@OutputTimeUnit(TimeUnit.MICROSECONDS)
@AutoService(OrcBenchmark.class)
-@Fork(jvmArgsAppend = "--add-opens=java.base/sun.nio.ch=ALL-UNNAMED")
+@Fork(jvmArgsAppend = {"--add-opens=java.base/sun.nio.ch=ALL-UNNAMED",
"--add-opens=java.base/sun.util.calendar=ALL-UNNAMED"})
Review Comment:
```java
Caused by: java.lang.IllegalAccessException: symbolic reference class is not
accessible: class sun.util.calendar.ZoneInfo, from interface
org.apache.spark.sql.catalyst.util.SparkDateTimeUtils (unnamed module @2b71fc7e)
at
java.base/java.lang.invoke.MemberName.makeAccessException(MemberName.java:955)
at
java.base/java.lang.invoke.MethodHandles$Lookup.checkSymbolicClass(MethodHandles.java:3686)
at
java.base/java.lang.invoke.MethodHandles$Lookup.resolveOrFail(MethodHandles.java:3646)
at
java.base/java.lang.invoke.MethodHandles$Lookup.findVirtual(MethodHandles.java:2680)
at
org.apache.spark.sql.catalyst.util.SparkDateTimeUtils.$init$(SparkDateTimeUtils.scala:206)
at
org.apache.spark.sql.catalyst.util.DateTimeUtils$.<clinit>(DateTimeUtils.scala:41)
```
##########
java/bench/spark/src/java/org/apache/orc/bench/spark/SparkBenchmark.java:
##########
@@ -198,8 +198,8 @@ public void fullRead(InputSource source,
default:
break;
}
- Seq<Tuple2<String,String>> optionsScala = JavaConverters
- .asScalaBufferConverter(options).asScala().toSeq();
+ Seq<Tuple2<String, String>> optionsScala = JavaConverters
+ .asScalaBufferConverter(options).asScala().toList();
Review Comment:
```
scala.collection.Seq<scala.Tuple2<java.lang.String,java.lang.String>> can't
convert to scala.collection.immutable.Seq
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
