al13n321 opened a new pull request, #1947: URL: https://github.com/apache/orc/pull/1947
Writer used C++ `char` type for calculating min/max statistics for columns of type BYTE. This works differently on platforms where `char` is signed (e.g. x86) vs unsigned (e.g. ARM). The correct behavior is to use a signed type. This PR changes `char` to `signed char`. Tested as part of ClickHouse here: https://github.com/ClickHouse/ClickHouse/pull/64563 . Let me know if I should add a unit test or something (though presumably there are already unit tests for this, they just don't run on ARM in CI?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
