ffacs commented on code in PR #1956:
URL: https://github.com/apache/orc/pull/1956#discussion_r1637741115
##########
c++/src/ByteRLE.cc:
##########
@@ -63,6 +63,11 @@ namespace orc {
virtual void suppress() override;
+ /**
+ * Finish encoding the stream.
Review Comment:
The statement is a little bit confusing.
##########
c++/src/RLEv1.cc:
##########
Review Comment:
We can rewrite `RleEncoderV1::flush()` with `finishEncode()` to make it
clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
