wgtmac commented on code in PR #1963:
URL: https://github.com/apache/orc/pull/1963#discussion_r1663450145
##########
.github/workflows/build_and_test.yml:
##########
@@ -197,3 +197,29 @@ jobs:
with:
config: .github/.licenserc.yaml
+ macos-c++-check:
+ name: "C++ Test on macOS"
+ strategy:
+ fail-fast: false
+ matrix:
+ version: [12, 14]
+
+ runs-on: macos-${{ matrix.version }}
+
+ steps:
+ - name: Checkout repository
+ uses: actions/checkout@v4
+
+ - name: Install dependencies
+ run: |
+ brew update
+ brew install protobuf
+
+ - name: Test
Review Comment:
```suggestion
name: "C++ Test on macOS"
strategy:
fail-fast: false
matrix:
version: [12, 14]
runs-on: macos-${{ matrix.version }}
steps:
- name: Checkout repository
uses: actions/checkout@v4
- name: Install dependencies
run: |
brew update
brew install protobuf
- name: Test
```
Let's make it compact
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
