dongjoon-hyun commented on code in PR #1990:
URL: https://github.com/apache/orc/pull/1990#discussion_r1692205295
##########
java/shims/src/java/org/apache/orc/impl/HadoopShims.java:
##########
@@ -132,13 +131,19 @@ ByteBuffer readBuffer(int maxLength,
*/
boolean endVariableLengthBlock(OutputStream output) throws IOException;
- default boolean supportVectoredIO() {
- // HADOOP-18103 is available since Apache Hadoop 3.3.5+
- String[] versionParts = VersionInfo.getVersion().split("[.]");
- int major = Integer.parseInt(versionParts[0]);
- int minor = Integer.parseInt(versionParts[1]);
- int patch = Integer.parseInt(versionParts[2]);
- return major == 3 && (minor > 3 || (minor == 3 && patch > 4));
+ default boolean supportVectoredIO(String version) {
Review Comment:
This change is okay for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
