wgtmac commented on code in PR #2038:
URL: https://github.com/apache/orc/pull/2038#discussion_r1779339841
##########
c++/src/io/OutputStream.hh:
##########
@@ -74,6 +74,11 @@ namespace orc {
virtual bool isCompressed() const {
return false;
}
+
+ virtual bool isBlockCompressed() const {
Review Comment:
I would be against adding this to the `BufferedOutputStream`. We already
have `isCompressed()` above, we can use static_cast to get a
`CompressionStream` and call this from there. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
