taiyang-li commented on code in PR #2048:
URL: https://github.com/apache/orc/pull/2048#discussion_r1814189625
##########
c++/src/MemoryPool.cc:
##########
@@ -86,10 +86,6 @@ namespace orc {
for (uint64_t i = currentSize_; i > newSize; --i) {
(buf_ + i - 1)->~T();
}
- } else if (newSize > currentSize_) {
- for (uint64_t i = currentSize_; i < newSize; ++i) {
- new (buf_ + i) T();
Review Comment:
There is performance benefits if we remove it. In fact, similar optimization
exists in ClickHouse.
If you find any code relying on it, please let me know. At least removing it
doesn't influence the CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
