wgtmac commented on code in PR #2121:
URL: https://github.com/apache/orc/pull/2121#discussion_r1926251715
##########
CMakeLists.txt:
##########
@@ -87,7 +87,7 @@ option(ORC_PACKAGE_KIND
option(ORC_ENABLE_CLANG_TOOLS
"Enable Clang tools"
- ON)
+ OFF)
Review Comment:
`ORC_ENABLE_CLANG_TOOLS` was required by the previous GitHub workflow for
clang-tidy and clang-format enforcement. Now it is replaced by the
`cpp-linter-action` and is no longer needed. At the same time, it defines
custom targets like `check-clang-tidy` and `check-format` which may have name
conflict with other projects (like Apache Arrow). In many build environments
(like Conan or Github CIs) usually these tools are missing and result in
annoying warning messages. So I think it makes sense to disable it by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
