WillAyd opened a new pull request, #2298:
URL: https://github.com/apache/orc/pull/2298

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. File a JIRA issue first and use it as a prefix of your PR title, e.g., 
`ORC-001: Fix ABC`.
     2. Use your PR title to summarize what this PR proposes instead of 
describing the problem.
     3. Make PR title and description complete because these will be the 
permanent commit log.
     4. If possible, provide a concise and reproducible example to reproduce 
the issue for a faster review.
     5. If the PR is unfinished, use GitHub PR Draft feature.
   -->
   
   ### What changes were proposed in this pull request?
   This removes setting the Meson configuration to remove the buildtype of 
release by default. 
   
   ### Why are the changes needed?
   While coming from CMake it may seem like a good idea to build release builds 
by default, the setting is either ignored or problematic when orc is used as a 
subproject in other projects, especially on Windows where a main project 
building a library with debug symbols may fail if a subproject tries to force 
release symbols.
   
   
   ### How was this patch tested?
   Compiled locally
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to