ffacs commented on code in PR #2269: URL: https://github.com/apache/orc/pull/2269#discussion_r2178030573
########## c++/src/TypeImpl.cc: ########## @@ -780,6 +909,14 @@ namespace orc { uint64_t maxLength = static_cast<uint64_t>(atoi(input.substr(start + 1, end - start + 1).c_str())); return std::make_unique<TypeImpl>(CHAR, maxLength); + } else if (category == "geometry") { + if (input[start] != '(') { + throw std::logic_error("Missing ( after varchar."); Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@orc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org