taiyang-li commented on code in PR #2337:
URL: https://github.com/apache/orc/pull/2337#discussion_r2221450438
##########
c++/src/ColumnWriter.cc:
##########
@@ -962,8 +973,13 @@ namespace orc {
void clear();
private:
+ struct LessThan {
+ bool operator()(const DictEntryWithIndex& l, const DictEntryWithIndex&
r) {
+ return l.entry.data < r.entry.data; // use std::string's operator<
Review Comment:
Yes. `std::string` marks its ending with `length` field instead of `\0`.
<img width="575" height="182" alt="image"
src="https://github.com/user-attachments/assets/c854b014-6f07-409a-86a9-ab8408b3cd7b";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
