wgtmac commented on code in PR #2437:
URL: https://github.com/apache/orc/pull/2437#discussion_r2424084826
##########
cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -172,6 +172,12 @@ elseif (ORC_PACKAGE_KIND STREQUAL "vcpkg")
list (APPEND ORC_SYSTEM_DEPENDENCIES Protobuf)
list (APPEND ORC_INSTALL_INTERFACE_TARGETS
"$<INSTALL_INTERFACE:protobuf::libprotobuf>")
set (PROTOBUF_EXECUTABLE protobuf::protoc)
+elseif (TARGET ${ARROW_PROTOBUF_LIBPROTOBUF})
+ # Used by Apache Arrow only, remove this once Arrow leverages FetchContent
for Protobuf
+ add_library (orc_protobuf INTERFACE IMPORTED)
+ target_link_libraries(orc_protobuf INTERFACE ${ARROW_PROTOBUF_LIBPROTOBUF})
+ set (PROTOBUF_EXECUTABLE ${ARROW_PROTOBUF_PROTOC})
+ message(STATUS "Using existing ${ARROW_PROTOBUF_LIBPROTOBUF}")
Review Comment:
I was supposed to add this as a temporary solution for Apache Arrow. Apache
Arrow has already migrated `lz4` to use `FetchContent` so I don't need to do
anything and `FetchContent_Declare` in Apache ORC can automatically find it. I
assume Apache Arrow will eventually migrate all dependencies to use
`FetchContent`, am I correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@orc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
