wgtmac commented on code in PR #2461:
URL: https://github.com/apache/orc/pull/2461#discussion_r2610591059
##########
c++/src/ColumnWriter.cc:
##########
@@ -1038,6 +1038,8 @@ namespace orc {
if (!useDictionary) {
directLengthEncoder->add(length, numValues, notNull);
+ } else if (dictionary.capacity() < numValues) {
Review Comment:
This looks weird. Is it better to grow its size only when required? I think
the map internally can optimize this by reserving a larger number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
