cxzl25 commented on code in PR #2504:
URL: https://github.com/apache/orc/pull/2504#discussion_r2744762281
##########
java/tools/pom.xml:
##########
@@ -56,6 +56,12 @@
</exclusion>
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-lang3</artifactId>
+ <!-- convert tool CSVParser uses org.apache.commons.lang3 -->
+ <scope>runtime</scope>
Review Comment:
If it is declared as compile scope, the check of maven-dependency-plugin
will report an error, so only runtime scope can be used.
```java
[INFO] --- dependency:3.9.0:analyze-only (default) @ orc-tools ---
[ERROR] Unused declared dependencies found:
[ERROR] org.apache.commons:commons-lang3:jar:3.20.0:compile
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
