ffacs commented on code in PR #2639:
URL: https://github.com/apache/orc/pull/2639#discussion_r3419735486


##########
c++/src/CpuInfoUtil.cc:
##########
@@ -374,6 +379,17 @@ namespace orc {
       return flags;
     }
 
+#if defined(CPUINFO_ARCH_RISCV)
+    int64_t LinuxParseRiscvIsa(const std::string& values) {
+      int64_t flags = 0;
+      // RISC-V ISA string like "rv64imafdcv" contains 'v' for vector extension
+      if (values.find('v') != std::string::npos) {

Review Comment:
   This is always true



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to