bharatviswa504 commented on a change in pull request #1526:
URL: https://github.com/apache/ozone/pull/1526#discussion_r516427783
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/safemode/HealthyPipelineSafeModeRule.java
##########
@@ -118,7 +118,7 @@ protected void process(Pipeline pipeline) {
Preconditions.checkNotNull(pipeline);
if (pipeline.getType() == HddsProtos.ReplicationType.RATIS &&
pipeline.getFactor() == HddsProtos.ReplicationFactor.THREE &&
- pipeline.isHealthy() &&
+ // pipeline.isHealthy() &&
Review comment:
I understand now why we can remove this, we trigger open Pipeline event
when healthy only. Can we remove the code comment completely.
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/safemode/HealthyPipelineSafeModeRule.java
##########
@@ -118,7 +118,7 @@ protected void process(Pipeline pipeline) {
Preconditions.checkNotNull(pipeline);
if (pipeline.getType() == HddsProtos.ReplicationType.RATIS &&
pipeline.getFactor() == HddsProtos.ReplicationFactor.THREE &&
- pipeline.isHealthy() &&
+ // pipeline.isHealthy() &&
Review comment:
do we want to remove this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
