prashantpogde commented on a change in pull request #1508: URL: https://github.com/apache/ozone/pull/1508#discussion_r518537222
########## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NonHealthyToReadOnlyHealthyNodeHandler.java ########## @@ -0,0 +1,65 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hdds.scm.node; + +import java.util.Set; + +import org.apache.hadoop.hdds.conf.ConfigurationSource; +import org.apache.hadoop.hdds.conf.OzoneConfiguration; +import org.apache.hadoop.hdds.protocol.DatanodeDetails; +import org.apache.hadoop.hdds.scm.pipeline.PipelineID; +import org.apache.hadoop.hdds.scm.pipeline.PipelineManager; +import org.apache.hadoop.hdds.server.events.EventHandler; +import org.apache.hadoop.hdds.server.events.EventPublisher; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Handles Stale node event. + */ +public class NonHealthyToReadOnlyHealthyNodeHandler + implements EventHandler<DatanodeDetails> { + + private static final Logger LOG = + LoggerFactory.getLogger(NonHealthyToReadOnlyHealthyNodeHandler.class); + private final PipelineManager pipelineManager; + private final NodeManager nodeManager; + private final ConfigurationSource conf; + + public NonHealthyToReadOnlyHealthyNodeHandler( + NodeManager nodeManager, PipelineManager pipelineManager, + OzoneConfiguration conf) { + this.pipelineManager = pipelineManager; + this.nodeManager = nodeManager; + this.conf = conf; + } + + @Override + public void onMessage(DatanodeDetails datanodeDetails, + EventPublisher publisher) { + Set<PipelineID> pipelineIds = + nodeManager.getPipelines(datanodeDetails); + LOG.info("Datanode {} moved to HEALTH READ ONLY state.", + datanodeDetails); + if (!pipelineIds.isEmpty()) { + LOG.error("Datanode {} is part of pipelines {} in HEALTH READ ONLY " + + "state.", + datanodeDetails, pipelineIds); + } Review comment: Yes, because this condition should never happen. Nodes are moved to this state as part of finalizeUpgrade process on SCM. This will be another PR on of this one. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
