linyiqun commented on pull request #1555: URL: https://github.com/apache/ozone/pull/1555#issuecomment-723025948
@sadanand48 , current unit test cases only cover the basic functionality of trash delete behavior. But here we introduce many new setting, like trash interval, emptier interval. Can we add more test case to cover this? In additional, will Ozone trash feature also support S3 semantic path later? Like we accidentally delete one key /vol/bucket/key (not a ozfs path), then we can recover this key from a trash path. I see currently we implement this only for FS semantic path. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
