elek commented on pull request #1419: URL: https://github.com/apache/ozone/pull/1419#issuecomment-724776405
> I think if you really want to proceed with this idea, you should update your design doc to describe in detail just the initial/phase 1 changes of capturing existing storage classes. The rest can be moved to future/addendum section, then it will be easier to review your patch. Thank you very much the comments, it was a great help. I updated the document based on your feedback and I believe it's more clear and understandable now. 1. It clearly talks only about the current plan. A few exceptions: future plans are moved to the last section to show some context but clearly stated that it's not part of the plan. HOT/COLD data is also explained, but marked as out of the scope. It is included because it was a specific question during the discussions. 2. Based on your feedback I found that the flexibility level is not very clear, therefore are made it more explicit everywhere. That's the biggest change in the commit. Instead of talking about storage-class which is the definition of transitions of states I talk about storage-class as a selection of a replication mechanism (which already has implementation) and the configuration of the replication (eg. set the factor for closed containers). I believe this change makes it clear that our opinion is closer: I don't think that we need a very flexible way to combine and container states. (Earlier version of this document used more flexible context, but I learned from the feedback). > I am not yet convinced that the effort to introduce custom new storage classes is worth it. The only immediate use case is EC which can be solved lot more easily with HDFS-like EC policies. The other use case is the replication factor TWO, which was a request by our early adopters and tested by @maobaolong based on this concept. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
