adoroszlai commented on a change in pull request #1569:
URL: https://github.com/apache/ozone/pull/1569#discussion_r525874645
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##########
@@ -2209,14 +2205,18 @@ private void listStatusFindKeyInTableCache(
bucketName);
}
+ List<OmKeyInfo> keyInfoList = new ArrayList<>(fileStatusList.size());
for (OzoneFileStatus fileStatus : fileStatusList) {
- if (args.getRefreshPipeline()) {
- refreshPipeline(fileStatus.getKeyInfo());
- }
- if (args.getSortDatanodes()) {
+ keyInfoList.add(fileStatus.getKeyInfo());
+ }
+ refreshPipeline(keyInfoList);
Review comment:
> Then this might be a problem for listKeys also, but do you see this as
a problem?
I don't see this as an immediate problem.
As far as I understand, batch size for `listKeys` and `listStatus` is a
convenience for the client, not a safety guarantuee for the server. If RPC
response size is a problem when performing `getContainerWithPipelineBatch` call
for multiple keys, then the same can be triggered by the client simply by
increasing batch size (if there are enough keys in the bucket).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
