adoroszlai edited a comment on pull request #1572: URL: https://github.com/apache/ozone/pull/1572#issuecomment-730253599
Thanks @elek for merging it and @avijayanhwx for the review. > Based on my understanding HADOOP_HOME was usable earlier to point to any Ozone install, now it's forced to point a specific dir. The script is happy as long as it finds the `ozone-config.sh` file, does not care about specific directories, versions or instances. HADOOP_HOME is only forced if it does not already point to any Ozone install, rather to Hadoop or something completely different or maybe a non-existent dir. In this case, `ozone` (and `stop-ozone.sh`) did not work prior to this change. Also, as long as Ozone scripts are executed, not sourced, updating the variables does not affect the caller. Normally HADOOP_HOME and other environment variables can be defined for each component separately. However, in an Impala mini cluster (used for running tests), all components share the same environment. HADOOP_HOME points to Hadoop, so we need a way to override this "locally" for Ozone. This change allows that without extensive and potentially dangerous refactoring (renaming all HADOOP variables and updating Ozone's copy of hadoop functions etc.). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
