captainzmc commented on pull request #1629: URL: https://github.com/apache/ozone/pull/1629#issuecomment-734565064
> Thanks @captainzmc for proposing improvement to the documentation. > > I think config in files separate from regular code is preferred for maintainability (ie. `ozone-site.xml`, which is picked up from the classpath). Instead of an example that hard-codes addresses in the code, I think we should provide an overview page about the XML-based config. > > Config specific to OM HA is described in _Features > High Availability_, while required config for regular OM is listed in _Architecture > Ozone Manager_. Agree, when I personally run the Ozone API, I usually put configuration files in my environment (such as Ozone -site.xml) under the Classpath resource, so that no configuration is required in the code. I only ask people to write the OM configuration to their code if they don't want to use the configuration file. Perhaps we can emphasize here that we prefer to use a configuration file to load the configuration of the client. we can also lists the necessary configuration items in ozone-site.xml on the client. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
