amaliujia commented on a change in pull request #1650: URL: https://github.com/apache/ozone/pull/1650#discussion_r534536573
########## File path: hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/ha/TestRelicationAnnotation.java ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with this + * work for additional information regarding copyright ownership. The ASF + * licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * <p/> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p/> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.hadoop.hdds.scm.ha; + +import java.io.IOException; +import org.apache.hadoop.hdds.protocol.proto.SCMRatisProtocol.RequestType; +import org.apache.hadoop.hdds.scm.metadata.Replicate; +import org.junit.Before; +import org.junit.Test; + +/** + * Tests on {@link org.apache.hadoop.hdds.scm.metadata.Replicate}. + */ +public class TestRelicationAnnotation { + private SCMHAInvocationHandler scmhaInvocationHandler; + + @Before + public void setup() { + scmhaInvocationHandler = new SCMHAInvocationHandler( + RequestType.CONTAINER, + null, + new MockRatisServer()); + } + + @Test(expected = IOException.class) + public void testReplicateAnnotationBasic() throws Throwable { + // test whether replicatedOperation will hit the Ratis based replication + // code path in SCMHAInvocationHandler. Expect to see a IOException cause + // no handler is added yet. + scmhaInvocationHandler.invoke(new Object(), + this.getClass().getMethod("replicatedOperation"), new Object[0]); + } + + @Replicate + public void replicatedOperation() { } Review comment: Should I actually mock a InvocationHandler and add a request type `RequestType.Test`? Then make sure `replicatedOperation` is eventually called. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
