bharatviswa504 commented on a change in pull request #1642:
URL: https://github.com/apache/ozone/pull/1642#discussion_r535854667



##########
File path: 
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/exception/S3ErrorTable.java
##########
@@ -105,6 +106,9 @@ private S3ErrorTable() {
       "InternalError", "We encountered an internal error. Please try again.",
       HTTP_SERVER_ERROR);
 
+  public static final OS3Exception PERMISSION_DENIED = new OS3Exception(

Review comment:
       Do we think, we want to change it to AccessDenied, to be closer to S3
   
   
https://docs.aws.amazon.com/AmazonS3/latest/API/ErrorResponses.html#RESTErrorResponses
   
   AccessDenied 403
   
   https://aws.amazon.com/premiumsupport/knowledge-center/s3-troubleshoot-403/ 
Even though we don't have S3 Acls, Ozone Acls causing this, but to be close to 
S3 I think error code having same might be better here IMHO.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to